RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
Chen Liang
liach at openjdk.org
Mon Dec 9 14:11:42 UTC 2024
On Thu, 5 Dec 2024 23:27:38 GMT, Scott Marlow <duke at openjdk.org> wrote:
>>> I made a quick test for this, but you might not want to include it if you aim to backport this improvement to LTS releases as it uses the recently-finalized ClassFile API.
>>
>> Excellent, I'm +1000 for adding your test, thank you very much for creating it! Can you create a pr against https://github.com/scottmarlow/jdk/tree/AnnotationParser_should_include_container_Duplicate_annotation_error or add the commit directly to this pr?
>
>> @scottmarlow I plan to do a separate PR to add this test; so we get a clean commit that can be easily backported to 24 and existing LTS versions.
>
> Thanks, that sounds great as well!
>
> Thanks to you and others in the community that helped me with this!
@scottmarlow If you want this patch committed, you need to issue the `/integrate` command yourself.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22581#issuecomment-2528066375
More information about the core-libs-dev
mailing list