RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v4]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Dec 9 21:06:09 UTC 2024
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` without explicit `--module-path` option. In addition this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and `--limit-modules` are used in combination it failed earlier and passes now due to alignment of `ModuleFinder`s. With this patch JEP 493 enabled builds and regular JDK builds behave the same in terms of `ALL-MODULE-PATH`.
>
> When an explicit module path is being added, there is no difference. All modules on that path will be added as roots. Tests have been added for the same. Thoughts?
>
> Testing:
> - [x] GHA, `test/jdk/tools/jlink` (all pass)
> - [x] Added jlink test.
Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
Fix JLinkTest.java
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22494/files
- new: https://git.openjdk.org/jdk/pull/22494/files/15116a67..2f1934f3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22494&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22494&range=02-03
Stats: 6 lines in 1 file changed: 1 ins; 3 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/22494.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22494/head:pull/22494
PR: https://git.openjdk.org/jdk/pull/22494
More information about the core-libs-dev
mailing list