RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path
Severin Gehwolf
sgehwolf at openjdk.org
Tue Dec 10 12:06:20 UTC 2024
On Fri, 6 Dec 2024 18:33:06 GMT, Mandy Chung <mchung at openjdk.org> wrote:
> Such behavioral change is a good change as jlink from the default and --generate-linkable-runtime build would have the consistent behavior. If a module path is given with no root module (empty path), it throws the following error. I think it can throw a similar message as if `--add-modules ALL-MODULE-PATH` is given but no `--module-path`.
>
> ```
> $ jlink --add-modules ALL-MODULE-PATH --output myimage --module-path emptyPath
> Error: Cannot invoke "java.nio.file.Path.getFileName()" because "javaBasePath" is null
> java.lang.NullPointerException: Cannot invoke "java.nio.file.Path.getFileName()" because "javaBasePath" is null
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.isJavaBaseFromDefaultModulePath(JlinkTask.java:660)
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.targetPlatform(JlinkTask.java:632)
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.createImageProvider(JlinkTask.java:569)
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.createImage(JlinkTask.java:410)
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.run(JlinkTask.java:285)
> at jdk.jlink/jdk.tools.jlink.internal.Main.run(Main.java:56)
> at jdk.jlink/jdk.tools.jlink.internal.Main.main(Main.java:34)
> ```
Thanks, yes. Added.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22494#issuecomment-2531411955
More information about the core-libs-dev
mailing list