RFR: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used [v3]

Severin Gehwolf sgehwolf at openjdk.org
Wed Dec 11 19:27:18 UTC 2024


On Wed, 11 Dec 2024 17:42:29 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Mandy's feedback
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 396:
> 
>> 394:             Path defModPath = getDefaultModulePath();
>> 395:             if (defModPath != null) {
>> 396:                 options.modulePath.add(defModPath);
> 
> Default module path has already been added if `--module-path is not set` [1].   It's okay to leave it as is as line 281-287 will be removed by https://github.com/openjdk/jdk/pull/22494.
> 
> https://github.com/openjdk/jdk/blob/master/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java#L281

Yes, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22609#discussion_r1880785257


More information about the core-libs-dev mailing list