RFR: 8345687: Improve the implementation of SegmentFactories::allocateSegment [v3]

Quan Anh Mai qamai at openjdk.org
Wed Dec 11 19:29:15 UTC 2024


On Wed, 11 Dec 2024 18:50:18 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> I want to put it here so that even if `SegmentFactories::allocateNative` is not inlined, this small method will be more likely to be inlined and the segment can be non-escape, then. I have added a comment regarding class initialization cycles.
>
> I understand, but can't we then move this method to `SegmentFactories` - e.g. maybe have a private `allocateNativeInternal` and an `allocateNative` ?

That's reasonable. I have done so.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22610#discussion_r1880786863


More information about the core-libs-dev mailing list