RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v2]

Martin Balao mbalao at openjdk.org
Wed Dec 11 21:10:41 UTC 2024


On Fri, 6 Dec 2024 18:34:00 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Algorithms renamed for alignment with SunJCE.
>>   
>>   Co-authored-by: Martin Balao Alonso <mbalao at redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KDF.java line 188:
> 
>> 186:                 }
>> 187:             } else {
>> 188:                 ret = P11Key.secretKey(session, derivedObjectID, alg, outLen,
> 
> Is the key length in bytes or bits here?

Good question. Should be converted to bits. The same issue repeats one more time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1881000882


More information about the core-libs-dev mailing list