RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v4]

[Martin Balao]

On Thu, 12 Dec 2024 01:10:04 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make EMPTY_KEY static.
>>   
>>   Co-authored-by: Martin Balao Alonso <mbalao at redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KDF.java line 154:
> 
>> 152:         long saltType = CKF_HKDF_SALT_NULL;
>> 153:         byte[] saltBytes = null;
>> 154:         P11Key p11SaltKey = null;
> 
> For `Expand`, `salt` is null.
> 
> Did you test with assertion on?

For Expand, `salt` should be `null`. Do you mean adding or hitting an assertion?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1881268883