RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v7]

Severin Gehwolf sgehwolf at openjdk.org
Thu Dec 12 18:30:54 UTC 2024


> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` without explicit `--module-path` option or a non-existent module path. In addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and `--limit-modules` are used in combination. It failed earlier and passes now due to alignment of `ModuleFinder`s. With this patch JEP 493 enabled builds and regular JDK builds behave the same in terms of `ALL-MODULE-PATH`.
> 
> When an explicit module path is being added, there is no difference. All modules on that path will be added as roots. Tests have been added for the various cases and existing tests updated to allow for them to run on JEP 493 enabled builds. Thoughts?
> 
> Testing:
> - [x] GHA, `test/jdk/tools/jlink` (all pass)
> - [x] Added jlink test.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 31 commits:

 - Guard test execution
 - Merge branch 'master' into jdk-8345259-all-module-path-fix
 - More test clean-ups
 - Merge two AllModulePath tests
 - Better error message with no modules on mod-path and ALL-MODULE-PATH
 - Merge branch 'jdk-8345573-runtime-link-limit-mods' into jdk-8345259-all-module-path-fix
 - Naming fixes
 - Remove too strong assertion
 - Test fixes
 - Address comments from Mandy
 - ... and 21 more: https://git.openjdk.org/jdk/compare/ff85865b...b577b4da

-------------

Changes: https://git.openjdk.org/jdk/pull/22494/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22494&range=06
  Stats: 297 lines in 5 files changed: 228 ins; 39 del; 30 mod
  Patch: https://git.openjdk.org/jdk/pull/22494.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22494/head:pull/22494

PR: https://git.openjdk.org/jdk/pull/22494


More information about the core-libs-dev mailing list