RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v7]

Mandy Chung mchung at openjdk.org
Fri Dec 13 18:57:42 UTC 2024


On Fri, 13 Dec 2024 14:11:44 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> We have:
>> - `testLimitModules()` limits on a module from the module path, `m1`. It expects `m1` and it's dependencies in the image.
>> - `testAddModules()` limits on a module dependency, but has modules from the module path added explicitly: `m1` and `test`. Therefore, expects `m1` and `test` as well as there deps in the image.
>> - `modulePathWithLimitMods()` limits on a module dependency, but doesn't include any other module with the `--add-modules` option. Therefore, only expects `jdk.jfr` and its dependency, `java.base` to be included in the image.
>> 
>> They are all slightly different and it's useful to test all 3 combinations.
>
> I've tried to clarify the cases with comments.

Indeed useful tests.   This uncovers an issue about `--limit-modules`.  Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1884356334


More information about the core-libs-dev mailing list