RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image [v12]
Mandy Chung
mchung at openjdk.org
Fri Dec 13 23:09:38 UTC 2024
On Fri, 13 Dec 2024 23:05:32 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move up Snippet setup as a builder
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java line 1136:
>
>> 1134: /*
>> 1135: * SetReference count references to the set, and use LoadableSet under the hood to
>> 1136: * support paginiation as needed.
>
> Suggestion:
>
> * support pagination as needed.
The code has been refactored. The comment should be updated to reflect the new code?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21022#discussion_r1884633866
More information about the core-libs-dev
mailing list