RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v8]

Severin Gehwolf sgehwolf at openjdk.org
Mon Dec 16 10:18:40 UTC 2024


On Fri, 13 Dec 2024 18:44:55 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Test cleanup
>>  - Only use the combined list when creating the finder
>
> test/jdk/tools/jlink/basic/AllModulePath.java line 258:
> 
>> 256:      * Verify linked modules using java --list-modules
>> 257:      */
>> 258:     private void verifyListModules(Path targetPath, List<String> expected) throws Exception {
> 
> Suggestion:
> 
>     private void verifyListModules(Path targetPath, Set<String> expected) throws Exception {
> 
> 
> Can simply use a Set to compare the result and  no need to sort `actual` from the output.

OK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1886546039


More information about the core-libs-dev mailing list