RFR: 8345185: Update jpackage to not include service bindings by default [v2]

Severin Gehwolf sgehwolf at openjdk.org
Mon Dec 16 20:21:06 UTC 2024


On Mon, 9 Dec 2024 18:17:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> test/jdk/tools/jpackage/share/BasicTest.java line 323:
>> 
>>> 321:                return;
>>> 322:             }
>>> 323:         }
>> 
>> The better alternative would be to use `@ParameterSupplier` annotation instead of the list of `@Parameter` to dynamically configure the input for testAddModules() test case. You can use https://github.com/openjdk/jdk/blob/master/test/jdk/tools/jpackage/share/ErrorTest.java or https://github.com/openjdk/jdk/blob/cc628a133e471e7edf07831ff386f0eaf57e9bff/test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/AnnotationsTest.java#L97 as an example.
>
> OK, thank you.

Fixed in the update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22644#discussion_r1887534306


More information about the core-libs-dev mailing list