RFR: 8345185: Update jpackage to not include service bindings by default [v2]

Severin Gehwolf sgehwolf at openjdk.org
Tue Dec 17 11:30:46 UTC 2024


On Tue, 17 Dec 2024 03:03:13 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Refactor BasicTest.java according to review
>>  - Don't resolve service bindings by default
>>  - Revert "Handle ALL-DEFAULT in jpackage tool"
>>    
>>    This reverts commit ca506f85f67f495cd29e8f9ff1a7004c9888aaaf.
>>  - Merge branch 'master' into jdk-8345185-jpackage-all-default-fix
>>  - Adjust JLinkOptionsTest.java after JEP 493
>>  - Fix tests for JEP 493 enabled JDKs
>>  - Handle ALL-DEFAULT in jpackage tool
>>    
>>    When a JEP 493 enabled JDK is in use, the JMODs folder might not exist.
>>    Do some reasonable filtering based on that information. Otherwise, keep
>>    as-is.
>
> test/jdk/tools/jpackage/share/BasicTest.java line 79:
> 
>> 77:         boolean noJmods = Files.notExists(jmods);
>> 78:         if (LinkableRuntimeImage.isLinkableRuntime() && noJmods) {
>> 79:            System.out.println("ALL-MODULE-PATH test skipped for linkable run-time image");
> 
> Please use `TKit.trace()` instead of `System.out.println()`

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22644#discussion_r1888359936


More information about the core-libs-dev mailing list