RFR: 8340493: Fix some Asserts failure messages [v2]

[Weijun Wang]

On Tue, 17 Dec 2024 12:57:08 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Are those calls from me? I know I haven't followed this pattern and I'm thinking about fixing them later.
>> 
>> The reason I want to make this change is to make it consistent with the current `assertEquals` method that shows " expected: LEFT but was: RIGHT". There are quite a lot of calls like `assertEquals(variable, "literal")`, but I think that's the callers' problem instead of the method's.
>
> Could you rename `lhs` and `rhs` to `expected` and `actual`? Just to avoid the problems mentioned in https://github.com/openjdk/jdk/pull/17952#issuecomment-1973131407

I added a new commit with the new names. Only methods I touched in this PR were updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21101#discussion_r1888668343