RFR: 8346300: Add @Test annotation to TCKZoneId.test_constant_OLD_IDS_POST_2024b test

Naoto Sato naoto at openjdk.org
Tue Dec 17 17:30:35 UTC 2024


On Tue, 17 Dec 2024 07:59:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> A very minor test fix.
>
> test/jdk/java/time/tck/java/time/TCKZoneId.java line 99:
> 
>> 97:     // SHORT_IDS
>> 98:     //-----------------------------------------------------------------------
>> 99:     @Test
> 
> A passing comment is that I personally find it confusing to see `@Test` on the class and the test methods. With TestNG then I think you can use one or the other. It looks like the intention here is to put the annotation on the methods and eventually migrate to JUnit, is that right?

May be. I cannot confirm it is the case though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22773#discussion_r1888935645


More information about the core-libs-dev mailing list