RFR: 8346132: fallbacklinker.cpp failed compilation due to unused variable

[David Holmes]

On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> A simple fix for removing an unused variable in fallbacklinker.cpp. This is needed for building zero jvm variant on macosx-x64.
> 
> Testing:
> 
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64

Changes requested by dholmes (Reviewer).

src/java.base/share/native/libfallbackLinker/fallbackLinker.c line 168:

> 166:   // attach thread
> 167:   JNIEnv* env;
> 168:   (*VM)->AttachCurrentThreadAsDaemon(VM, (void**) &env, NULL);

I think the variable should be used! This code should be checking for a failed attach!

-------------

PR Review: https://git.openjdk.org/jdk/pull/22799#pullrequestreview-2510779563
PR Review Comment: https://git.openjdk.org/jdk/pull/22799#discussion_r1889603945