RFR: 8340493: Fix some Asserts failure messages [v2]

Daniel Jeliński djelinski at openjdk.org
Wed Dec 18 08:11:49 UTC 2024


On Tue, 17 Dec 2024 15:07:26 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which sounds redundant, just say "expected not equals but was 12345".
>> 
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...". Modify it to follow the `assertEquals` style ""expected... but was...".
>
> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8340493
>  - rename to expected, unexpected, and actual
>  - the fix

LGTM.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21101#pullrequestreview-2511084544


More information about the core-libs-dev mailing list