RFR: 8346468: SM cleanup of common test library

Daniel Fuchs dfuchs at openjdk.org
Wed Dec 18 16:56:36 UTC 2024


On Wed, 18 Dec 2024 15:00:13 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> SM Cleanup of common test library test/lib/...:
> 
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and ProcessTools.

LGTM

test/lib/jdk/test/lib/net/SimpleHttpServer.java line 105:

> 103:                         uri = URI.create("file://" + rootUri.getRawPath() + path).normalize();
> 104:                         fPath = Path.of(uri);
> 105:                     } catch (IllegalArgumentException | FileSystemNotFoundException ex) {

Please also update Copyright years in this file

test/lib/jdk/test/lib/net/SimpleSSLContext.java line 60:

> 58:             if (f.exists()) {
> 59:                 try (FileInputStream fis = new FileInputStream(f)) {
> 60:                     init(fis, proto);

Please also update Copyright years in this file

-------------

PR Review: https://git.openjdk.org/jdk/pull/22814#pullrequestreview-2512379941
PR Review Comment: https://git.openjdk.org/jdk/pull/22814#discussion_r1890556386
PR Review Comment: https://git.openjdk.org/jdk/pull/22814#discussion_r1890555174


More information about the core-libs-dev mailing list