RFR: 8340493: Fix some Asserts failure messages [v4]
Valerie Peng
valeriep at openjdk.org
Thu Dec 19 19:33:38 UTC 2024
On Thu, 19 Dec 2024 12:33:40 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...". Modify it to follow the `assertEquals` style ""expected... but was...".
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>
> fix usages
Marked as reviewed by valeriep (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21101#pullrequestreview-2516010134
More information about the core-libs-dev
mailing list