RFR: 8346128: Comparison build fails due to difference in LabelTarget.html
Chen Liang
liach at openjdk.org
Thu Dec 19 21:30:41 UTC 2024
On Thu, 19 Dec 2024 16:48:33 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
> Please review this doc-only patch to fix an issue that causes the cmp-baseline build to fail.
>
> The snippet in `LabelTrget.java` showed a highly rare non deterministism in javadoc snippet generation, which will be fixed in [JDK-8346659](https://bugs.openjdk.org/browse/JDK-8346659), but we can fix the snippet now to stop the failures.
>
> Previously, "label" in "labelBinding" would be matched to either `CodeBuilder#labelBinding` or `LabelTarget#label` (about 50:50 chance of either happening). I repaced the substring with a regex which seems to fix the issue.
>
> This will need to be backported to JDK 24.
>
> TIA!
This needs to be backported to 24.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22834#pullrequestreview-2516260694
More information about the core-libs-dev
mailing list