Integrated: 8346128: Comparison build fails due to difference in LabelTarget.html
Nizar Benalla
nbenalla at openjdk.org
Fri Dec 20 10:18:42 UTC 2024
On Thu, 19 Dec 2024 16:48:33 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
> Please review this doc-only patch to fix an issue that causes the cmp-baseline build to fail.
>
> The snippet in `LabelTrget.java` showed a highly rare non deterministism in javadoc snippet generation, which will be fixed in [JDK-8346659](https://bugs.openjdk.org/browse/JDK-8346659), but we can fix the snippet now to stop the failures.
>
> Previously, "label" in "labelBinding" would be matched to either `CodeBuilder#labelBinding` or `LabelTarget#label` (about 50:50 chance of either happening). I repaced the substring with a regex which seems to fix the issue.
>
> This will need to be backported to JDK 24.
>
> TIA!
This pull request has now been integrated.
Changeset: 2a68f741
Author: Nizar Benalla <nbenalla at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2a68f741884e73c9ed8e5222e57f5ecb088b3cf7
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8346128: Comparison build fails due to difference in LabelTarget.html
Reviewed-by: jlahoda, liach, prappo
-------------
PR: https://git.openjdk.org/jdk/pull/22834
More information about the core-libs-dev
mailing list