RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v12]

[Alan Bateman]

On Wed, 18 Dec 2024 19:34:47 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Fix comment
>>  - Revert "Catch case of module not in dependency tree"
>>    
>>    This reverts commit bfac44659e7219afe472d0e61735df119065796d.
>>  - Revert "Fix comments"
>>    
>>    This reverts commit 92f0736a678c59035ee97563756017316aadbfe2.
>
>> This solution is simpler -- it can just detect if `ALL-MODULE-PATH` is used with `--limit-modules`, jlink just fails.
> 
> That seems like a good suggestion to remove the complexity and need to think what it means. It would avoid complexity in the other phases too.

> @AlanBateman OK for you too? Thanks!

So --limit-modules && --add-modules ALL-MODULE-PATH is an error, as is --add-modules ALL-MODULE-PATH without specifying --module-path. Happy with that. I don't have time to go through the test but Mandy has already reviewed so I think we are good.  I'm just wondering if this needs a CSR and also whether the man page needs update.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22494#issuecomment-2556845420