RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]
Alan Bateman
alanb at openjdk.org
Fri Dec 20 12:15:36 UTC 2024
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this change for the `jar` tool to gracefully handle the case where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and `--validate` expected to read the optional `--release` option as a file argument: `jar -d -f a.jar --release 9`
>> By adding a hidden GNU-style `--release` option, processing the optional arguments before in those two operation modes, the position is now no longer required to trail behind the `-f --file` option: `jar -d --release 9 -f a.jar`
>>
>>
>> ==============================
>> Test summary
>> ==============================
>> TEST TOTAL PASS FAIL ERROR
>> jtreg:test/jdk/tools/jar 26 26 0 0
>> ==============================
>> TEST SUCCESS
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Add two more valid use-cases
test/jdk/tools/jar/ReleaseBeforeFiles.java line 26:
> 24: /*
> 25: * @test
> 26: * @bug 8167237 8316804
Have you looked at multiRelease/Basic.java, that might be a better place for this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22079#discussion_r1893867019
More information about the core-libs-dev
mailing list