RFR: 8302293: jar --create fails with IllegalArgumentException if archive name is shorter than 3 characters [v2]
Jaikiran Pai
jpai at openjdk.org
Fri Dec 20 14:15:14 UTC 2024
> Can I please get a review for this change which proposes to fix the issue noted in https://bugs.openjdk.org/browse/JDK-8302293?
>
> As noted in the issue, when creating a temporary file during the "jar --create" operation, if the original file name is lesser than 3 characters, the temporary file creation which uses the original file's name as the temporary file name prefix, runs into an exception. The commit in this PR addresses that issue by ensuring that the temporary file name prefix is atleast 3 characters in length. Within the same file, an additional place was spotted where the code could potentially run into the same exception, so that too has been addressed in this change.
>
> A new jtreg test has been introduced which reproduces the issue and verifies the fix.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
simplify assertion in test method
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22841/files
- new: https://git.openjdk.org/jdk/pull/22841/files/93c2a9fc..fd97b4d3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22841&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22841&range=00-01
Stats: 7 lines in 1 file changed: 1 ins; 4 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/22841.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22841/head:pull/22841
PR: https://git.openjdk.org/jdk/pull/22841
More information about the core-libs-dev
mailing list