RFR: 8323746: Add PathElement hashCode and equals

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Feb 1 15:04:02 UTC 2024


On Thu, 1 Feb 2024 14:25:24 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java line 454:
>> 
>>> 452:     }
>>> 453: 
>>> 454:     public static final class SequenceElement
>> 
>> Why are these not empty records?
>
> I had that in the beginning but converted them to regular classes as they do not have any record components. But maybe it is better to make them all records for consistency?

I think so, even less code :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17651#discussion_r1474622217


More information about the core-libs-dev mailing list