RFR: 8325109: Sort method modifiers in canonical order
Joe Darcy
darcy at openjdk.org
Thu Feb 1 17:24:01 UTC 2024
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> This is a follow-up on [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the bin/blessed-modifier-order.sh on the entire code base, and manually checked the result. I have reverted all but these trivial and uncontroversial changes.
>
> Almost all of these are about moving `static` to its proper position; a few do not involve `static` but instead puts `final` or `abstract` in the correct place.
>
> I have deliberately stayed away from `default` in this PR, since they should probably get a more thorough treatment, see https://github.com/openjdk/jdk/pull/17468#pullrequestreview-1829238473.
Looks fine; I just suggest double-checking on the current maintenance procedures for the java.util.concurrent code.
-------------
Marked as reviewed by darcy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17670#pullrequestreview-1857088376
More information about the core-libs-dev
mailing list