RFR: JDK-8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter [v2]

[Justin Lu]

On Fri, 2 Feb 2024 22:35:17 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reflect Naoto's comments
>
> src/java.base/share/classes/java/text/MessageFormat.java line 377:
> 
>> 375:  * Calendar cal = Calendar.getInstance();
>> 376:  * cal.set(123 + 1900, 10, 16);
>> 377:  * Object[] arg = {cal.getTime()};
> 
> Maybe with the following, better aligned with `java.time`'s example?
> 
> Object[] arg = {new GregorianCalendar(2023, Calendar.NOVEMBER, 16).getTime()};

Thanks, that's a lot more concise, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17663#discussion_r1476830875