RFR: 8324665: Loose matching of space separators in the lenient date/time parsing mode [v2]

Naoto Sato naoto at openjdk.org
Fri Feb 2 23:02:28 UTC 2024


On Fri, 2 Feb 2024 22:46:34 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reworded spec
>
> src/java.base/share/classes/java/text/DateFormat.java line 751:
> 
>> 749:      * @implSpec A {@link Character#SPACE_SEPARATOR SPACE_SEPARATOR} in the input
>> 750:      * text will match any other {@link Character#SPACE_SEPARATOR SPACE_SEPARATOR}s
>> 751:      * in the pattern with the lenient parsing; otherwise, it will not match.
> 
> LGTM.
> 
> Nit: Might read better as either "in the pattern with lenient parsing" or "in the pattern when parsing is lenient"

Thanks. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17678#discussion_r1476851850


More information about the core-libs-dev mailing list