RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v3]
Alan Bateman
alanb at openjdk.org
Tue Feb 6 12:57:54 UTC 2024
On Tue, 6 Feb 2024 12:30:10 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this doc-only change which updates the javadoc of several classes in `java.util.jar` and `java.util.zip` to specify their behaviour when `null` arguments are passed to the constructor or methods of those classes?
>>
>> For these updated classes, I have individually checked that they indeed throw a `NullPointerException` when `null` is passed to their constructor or methods. The couple of places where `null` is accepted have been updated to mention that `null` is allowed.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> Lance's review - replace can cause with will cause
The changes means that NPE is specified in both the class description and method descriptions in some cases, e.g. JarInputStream. I assume you meant to remove the NPE from methods where you've added a statement in the class description.
Minor nit is some of the usages of `<p>` in the change are inconsistent with the usages close by, you probably want to keep them consistent if you can.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17728#issuecomment-1929465055
More information about the core-libs-dev
mailing list