RFR: JDK-8325189: Enable this-escape javac warning in java.base

[Joe Wang]

On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> After the "this-escape" lint warning was added to javac (JDK-8015831), the base module was not updated to be able to compile with this warning enabled. This PR makes the necessary changes to allow the base module to build with the warning enabled.

The two XML changes look good to me. There would be a lot of warnings in the java.xml module as well, if we had to do it in the future.

-------------

Marked as reviewed by joehw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17692#pullrequestreview-1866004351