RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

[Jaikiran Pai]

On Wed, 7 Feb 2024 01:52:06 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this doc-only change which updates the javadoc of several classes in `java.util.jar` and `java.util.zip` to specify their behaviour when `null` arguments are passed to the constructor or methods of those classes?
>> 
>> For these updated classes, I have individually checked that they indeed throw a `NullPointerException` when `null` is passed to their constructor or methods. The couple of places where `null` is accepted have been updated to mention that `null` is allowed.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make <p> usage consistent with other similar usages in the file

Hello Alan,

> The changes means that NPE is specified in both the class description and method descriptions in some cases, e.g. JarInputStream. I assume you meant to remove the NPE from methods where you've added a statement in the class description.

I wasn't sure if I should remove them from the pre-existing method javadocs, so I had left them without changes. I have now updated the PR to remove them from the method level javadoc where we have now added the class level specification.

> 
> Minor nit is some of the usages of `<p>` in the change are inconsistent with the usages close by, you probably want to keep them consistent if you can.

Updated the PR to address this as well. I have updated it to match whatever the existing style (if any) was in that particular file.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17728#issuecomment-1931109866