RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]
Jaikiran Pai
jpai at openjdk.org
Wed Feb 7 10:10:54 UTC 2024
On Wed, 7 Feb 2024 09:41:40 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> make <p> usage consistent with other similar usages in the file
>
> src/java.base/share/classes/java/util/zip/DeflaterInputStream.java line 80:
>
>> 78: // "in" being null isn't allowed. we use a null check for "in"
>> 79: // merely to avoid an unnecessary instance creation of the Deflater
>> 80: // for such erroneous cases.
>
> I see this same comment has been added in 3 places but it's not easy to read and I don't think is needed.
I've now updated the PR to remove this code comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17728#discussion_r1481231121
More information about the core-libs-dev
mailing list