RFR: JDK-8325189: Enable this-escape javac warning in java.base [v2]

[Joe Darcy]

On Wed, 7 Feb 2024 19:28:11 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> After the "this-escape" lint warning was added to javac (JDK-8015831), the base module was not updated to be able to compile with this warning enabled. This PR makes the necessary changes to allow the base module to build with the warning enabled.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8325189
>  - JDK-8325189: Enable this-escape javac warning in java.base

Thanks all for the reviews. Will integrate now after a sync with mainline and successful cross-platform build run.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17692#issuecomment-1932778005