RFR: JDK-8323760 putIfAbsent documentation conflicts with itself [v2]

John Hendrikx jhendrikx at openjdk.org
Wed Feb 14 03:50:02 UTC 2024


On Tue, 13 Feb 2024 17:11:05 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Update the documentation for `@return` tag of `putIfAbsent` to match the main description. `putIfAbsent` uses the same wording as `put` for its `@return` tag, but that is incorrect.  `putIfAbsent` never returns the **previous** value, as the whole point of the method is not the replace the value if it was present.  As such, if it returns a value, it is the **current** value, and in all other cases it will return `null`.
>
> John Hendrikx has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Add code block around argument
>  - Reword
>  - Reword to use put's previous value wording
>  - Reword more clearly

CSR is available now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17438#issuecomment-1943040199


More information about the core-libs-dev mailing list