RFR: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin [v3]

[David Holmes]

On Mon, 5 Feb 2024 09:06:24 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for correct (Dekker scheme) synchronization with concurrent execution of [`AbstractInterruptibleChannel::begin`](https://github.com/openjdk/jdk/blob/59062402b9c5ed5612a13c1c40eb22cf1b97c41a/src/java.base/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java#L176).
>> 
>> The change passed our CI functional testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests.
>> Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.
>
> Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into 8323782__Race__Thread__interrupt_vs__AbstractInterruptibleChannel_begin
>  - Review Alan
>  - New version of LotsOfInterrupts.java supporting virtual threads
>  - Add Alan's LotsOfInterrupts.java test
>  - Must checkAccess before changing interrupt state of other thread
>  - 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin

Sorry for leaving this hanging. Change looks good.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17444#pullrequestreview-1881293498