RFR: 8318812: LauncherHelper.checkAndLoadMain closes jar file that's about to be re-opened [v2]
Alan Bateman
alanb at openjdk.org
Thu Feb 15 08:55:53 UTC 2024
On Thu, 15 Feb 2024 06:29:24 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this PR that makes the launcher helper keep a reference to the executable JAR file active after extracting the name of the main class and returning it as Class instance. Now, when loading classes from the JAR file, it hasn't to be re-opened.
>
> Christian Stein has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove `String jarname` from `getMainClassFromJar`'s signature
> - Introduce and use dedicated on-close error message
Updated version looks good to me.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17843#pullrequestreview-1882142536
More information about the core-libs-dev
mailing list