Integrated: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut

Eirik Bjørsnøs eirbjo at openjdk.org
Mon Feb 19 09:18:00 UTC 2024


On Sat, 17 Feb 2024 13:00:08 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this test-only cleanup PR in preparation for deprecating `Deflater.getTotalOut()` in JDK-8326096.
> 
> This PR replaces various calls in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to `Deflater.getTotalOut()` with calls to `Deflater.getBytesWritten()` when formatting some debugging output lines. 
> 
> Additionally, various debug output lines claim to print the result of calling `Deflater.getAdler`, but instead prints the output of `Deflater.getTotalOut'. This PR fixes this to print the actual Adler value instead.
> 
> Testing and verification: This is a test-only fix affecting only debug output. I have added the `noreg-self` label to the issue.

This pull request has now been integrated.

Changeset: 9451677d
Author:    Eirik Bjørsnøs <eirbjo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9451677daaf1184f67759c87114af3f81fa74f23
Stats:     13 lines in 1 file changed: 0 ins; 0 del; 13 mod

8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut

Reviewed-by: alanb, jpai

-------------

PR: https://git.openjdk.org/jdk/pull/17901


More information about the core-libs-dev mailing list