RFR: JDK-8324930: java/lang/StringBuilder problem with concurrent jtreg runs

[Jaikiran Pai]

On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> On some Windows machines we see sometimes OOM errors because of high resource (memory/swap) consumption. This is especially seen when the jtreg runs have higher concurrency. A solution is to put the java/lang/StringBuilder tests in the exclusiveAccess.dirs group so that they are not executed concurrently, which helps to mitigate the resource shortages.
> Of course this has the downside that on very large machines the concurrent execution is not done any more.

The other unanswered question is - why is this happening now? I did:


git log test/jdk/java/lang/StringBuilder/

which shows:


commit df22fb322e6c4c9931a770bd0abf4c43b83c4e4a
Author: Jim Laskey <jlaskey at openjdk.org>
Date:   Thu Jan 4 12:46:31 2024 +0000

    8322512: StringBuffer.repeat does not work correctly after toString() was called
    
    Reviewed-by: rriggs, jpai

commit 9b9b5a7a5c624f3512567f5d9b2e9eec231cabb3
Author: Jim Laskey <jlaskey at openjdk.org>
Date:   Mon Apr 3 15:29:21 2023 +0000

    8302323: Add repeat methods to StringBuilder/StringBuffer
    
    Reviewed-by: tvaleev, redestad

So there's been only 1 commit in that test directory since April 2023. That commit happened on Jan 4th 2024, but at first glance, that change itself doesn't look like something that can cause this issue. The JBS issue you filed is on Jan 30th 2024. Have you noticed such failures with these `test/jdk/java/lang/StringBuilder/` last year?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17625#issuecomment-1952476504