RFR: 8318812: LauncherHelper.checkAndLoadMain closes jar file that's about to be re-opened [v3]

Sean Coffey coffeys at openjdk.org
Mon Feb 19 15:46:54 UTC 2024


On Mon, 19 Feb 2024 15:42:05 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this PR that makes the launcher helper keep a reference to the executable JAR file active after extracting the name of the main class and returning it as Class instance. Now, when loading classes from the JAR file, it hasn't to be re-opened.
>
> Christian Stein has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Improve comment
>  - Update copyright year

Marked as reviewed by coffeys (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17843#pullrequestreview-1888733805


More information about the core-libs-dev mailing list