RFR: 8318812: LauncherHelper.checkAndLoadMain closes jar file that's about to be re-opened [v3]
Christian Stein
cstein at openjdk.org
Mon Feb 19 15:55:53 UTC 2024
On Thu, 15 Feb 2024 08:53:12 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> `String jarname` is filled by the caller with the value of `String what`, and therefore contains the entire path to the executable JAR file. Using only `jarFile.getName()` will prevent any parent directories from being noted in error messages; which might affect some tests
>
>> `String jarname` is filled by the caller with the value of `String what`, and therefore contains the entire path to the executable JAR file. Using only `jarFile.getName()` will prevent any parent directories from being noted in error messages; which might affect some tests
>
> It returns the path name so I think it does what we want. Do you observe a behavior difference?
No, I don't.
Also double-checked via `JarFile/ZipFile::getName`'s implementation returning the entire path to the JAR file.
Re-running tier1-3 tests just in case...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17843#discussion_r1494762559
More information about the core-libs-dev
mailing list