RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket [v5]

[Christoph Langer]

On Fri, 16 Feb 2024 16:39:33 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Typo
>>  - Merge branch 'master' into JDK-8325579
>>  - Rename test and refine comment
>>  - Enhance test
>>  - JDK-8325579
>
> test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeTest.java line 62:
> 
>> 60:  * whether the socket is closed after closing the Context.
>> 61:  *
>> 62:  * @run main/othervm --add-opens java.naming/javax.naming=ALL-UNNAMED --add-opens java.naming/com.sun.jndi.ldap=ALL-UNNAMED
> 
> sigh... git handles the renaming of this test file as a deleted file + a new file which makes it hard to review the changes.
> 
> The --add-opens directive are very strange here. I suggest removing them and replacing them with a single `@modules` directive:
> 
> 
> @modules java.naming/javax.naming:+open
>                   java.naming/com.sun.jndi.ldap:+open

Good suggestion. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1495579467