RFR: 8326096: Deprecate getTotalIn, getTotalOut methods of java.util.zip.Inflater, java.util.zip.Deflater [v2]

Eirik Bjørsnøs eirbjo at openjdk.org
Tue Feb 20 11:28:09 UTC 2024


On Tue, 20 Feb 2024 07:17:53 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix {@link #getBytesRead}
>
> src/java.base/share/classes/java/util/zip/Inflater.java line 644:
> 
>> 642:      * to <code>int</code>.
>> 643:      *
>> 644:      * @deprecated This method cannot safely return a result without a potential
> 
> Perhaps word this as:
>>
>>This method cannot return the right value when the number of compressed bytes is greater than {@link Integer.MAX_VALUE}. It is recommended that the {@link #getBytesRead()} method be used instead.

I've simplified the `@deprecated` note to the following:

> This method cannot return the correct value when the number of compressed bytes is 
> greater than {@link Integer#MAX_VALUE}. Use {@link #getBytesRead()} instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17919#discussion_r1495657905


More information about the core-libs-dev mailing list