RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket [v5]

Aleksei Efimov aefimov at openjdk.org
Wed Feb 21 18:28:54 UTC 2024


On Tue, 20 Feb 2024 10:28:37 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> Hm, I think the test was overpurposed already.  

This test was added by JDK-8314063 fix, and I do not think it was change after that.
 
> Creating another test file with duplicating code does not sound too good IMHO. Maybe it is acceptable without the renaming?

I think it is acceptable. Currently, it is hard to separate the test cases for `a)` the original [JDK-8314063](https://bugs.openjdk.org/browse/JDK-8314063) fix (the opened socket is not closed properly when connection timeout occurs) and `b)` the current fix [JDK-8325579](https://bugs.openjdk.org/browse/JDK-8325579) (unconnected sockets are not supported by SocketFactory). It would be great to have this distinction in the modified test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17797#issuecomment-1957632827


More information about the core-libs-dev mailing list