RFR: 8321156: Improve the handling of invalid UTF-8 byte sequences for ZipInputStream::getNextEntry and ZipFile::getComment [v2]
Lance Andersen
lancea at openjdk.org
Sat Feb 24 18:54:07 UTC 2024
On Sat, 24 Feb 2024 18:51:22 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Please review this PR which addresses the handling of invalid UTF-8 byte sequences in the entry name of a LOC file header and a Zip file comment which is returned via ZipFile::getComment.
>>
>> As part of the change, `ZipFile::getComment` will now return `null` if an invalid UTF-8 byte sequence is encountered while converting the byte array to a String. The CSR for this change has also been approved.
>>
>> Mach5 tiers 1-3 are clean with this change.
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>
> Updates based on 1st round of feedback
Thank you for your input Eirik, I have pushed updates to address the suggestions you raised
-------------
PR Review: https://git.openjdk.org/jdk/pull/17995#pullrequestreview-1899544786
More information about the core-libs-dev
mailing list