RFR: JDK-8326389: [test] improve assertEquals failure output [v3]
Jaikiran Pai
jpai at openjdk.org
Sun Feb 25 11:29:53 UTC 2024
On Thu, 22 Feb 2024 16:01:19 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Currently assertEquals has in the failure case sometimes confusing output like :
>>
>> java.lang.RuntimeException: VM output should contain exactly one RTM locking statistics entry for method compiler.rtm.locking.TestRTMTotalCountIncrRate$Test:🔒 expected 0 to equal 1
>> at jdk.test.lib.Asserts.fail(Asserts.java:634)
>> at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
>>
>> (I don't think we really expected that for some reason 0 equals 1)
>> This should be improved.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> assertEquals adjust output
Hello Christoph, in that case the `if` block I proposed can be removed. Does the alternate proposed error message look better to you and Matthias?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17952#issuecomment-1962901480
More information about the core-libs-dev
mailing list