RFR: 8323707: Adjust Classfile API's type arg model to better represent the embodied type [v3]

[Adam Sotona]

On Thu, 22 Feb 2024 05:38:19 GMT, Chen Liang <liach at openjdk.org> wrote:

>> API changes as discussed on the mailing list: https://mail.openjdk.org/pipermail/classfile-api-dev/2023-November/000419.html
>> 
>> Additional questions:
>> 1. Whether to rename `WildcardIndicator.DEFAULT` to `NONE`
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - Rename no wildcard indicator, improve docs slightly
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/typearg-model
>  - Merge branch 'master' into fix/typearg-model
>  - redundant line
>  - Fix a test in langtools, copyright year
>  - Merge branch 'master' of https://github.com/openjdk/jdk into fix/typearg-model
>  - Implementation cleanup, test update
>  - Merge branch 'master' into fix/typearg-model
>  - Formatting
>  - Nuke signatureString and fix test fialure from bad cast
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/0bcece99...62d25642

I would consider it for 2nd preview.
Please go ahead and propose the CSR.

test/jdk/jdk/classfile/SignaturesTest.java line 188:

> 186:         var arrayListSig = sig.superclassSignature(); // ArrayList
> 187:         var arrayListTypeArg = (TypeArg.Bounded) arrayListSig.typeArgs().getFirst(); // Outer<String>.Inner<Long>
> 188:         assertEquals(TypeArg.Bounded.WildcardIndicator.DEFAULT, arrayListTypeArg.wildcardIndicator());

Suggestion:

        assertEquals(TypeArg.Bounded.WildcardIndicator.NONE, arrayListTypeArg.wildcardIndicator());

test/langtools/tools/javap/classfile/6888367/T6888367.java line 320:

> 318:                     case EXTENDS -> "W{e," + print(b.boundType()) + "}";
> 319:                     case SUPER -> "W{s," + print(b.boundType()) + "}";
> 320:                     case DEFAULT -> print(b.boundType());

Suggestion:

                    case NONE -> print(b.boundType());

-------------

PR Review: https://git.openjdk.org/jdk/pull/16517#pullrequestreview-1900572367
PR Review Comment: https://git.openjdk.org/jdk/pull/16517#discussion_r1502422372
PR Review Comment: https://git.openjdk.org/jdk/pull/16517#discussion_r1502423113