RFR: 8321156: Improve the handling of invalid UTF-8 byte sequences for ZipInputStream::getNextEntry and ZipFile::getComment [v3]

Alan Bateman alanb at openjdk.org
Mon Feb 26 16:52:47 UTC 2024


On Mon, 26 Feb 2024 06:00:13 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>>> (In passing, the casing of "zip file" is very inconsistent in the javadoc, it's "ZIP file" in some places, "zip file" in others, the change here uses "Zip file").
>> 
>> Thank you for pointing out the discrepancy above.
>> 
>> Let's decide on which way to go and I will update  under a separate PR.
>> 
>> I would suggest "ZIP file" based on the PKWare APPNOTE.TXT, but the man pages for info-zip command _zip_ command uses "zip file"
>> 
>> Apache commons also uses "ZIP file" or "ZIP archive"
>
>> I would suggest "ZIP file" based on the PKWare APPNOTE.TXT,
> 
> I think using this case would be good.

> I would suggest "ZIP file" based on the PKWare APPNOTE.TXT, but the man pages for info-zip command _zip_ command uses "zip file"

"ZIP" is not an acronym so I assume this is why they use "zip" in their docs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17995#discussion_r1502980604


More information about the core-libs-dev mailing list