RFR: 8326433: Make file-local functions static in src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c [v2]

Jiangli Zhou jiangli at openjdk.org
Mon Feb 26 22:58:44 UTC 2024


On Mon, 26 Feb 2024 20:37:45 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Address plummercj's comment and make forkedChildProcess static.
>>  - Revert src/java.base/unix/native/libjava/childproc.c and src/java.base/unix/native/libjava/childproc.h. Will handle those with JDK-8326714.
>
> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 65:
> 
>> 63: // by this function. This function returns 0 on failure
>> 64: // and 1 on success.
>> 65: static int
> 
> I think you should also make forkedChildProcess static. It was added at the same time.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18013#discussion_r1503414683


More information about the core-libs-dev mailing list