RFR: 8326433: Make file-local functions static in src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c [v2]
Chris Plummer
cjplummer at openjdk.org
Mon Feb 26 23:52:44 UTC 2024
On Mon, 26 Feb 2024 22:55:06 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please help review this trivial fix for resolving `ld: error: duplicate symbol: closeDescriptors` when static linking with both libjdwp and libjava, thanks.
>
> Jiangli Zhou has updated the pull request incrementally with two additional commits since the last revision:
>
> - Address plummercj's comment and make forkedChildProcess static.
> - Revert src/java.base/unix/native/libjava/childproc.c and src/java.base/unix/native/libjava/childproc.h. Will handle those with JDK-8326714.
Looks good.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18013#pullrequestreview-1902255565
More information about the core-libs-dev
mailing list