RFR: 8326687: Inconsistent use of "ZIP", "Zip" and "zip" in java.util.zip/jar zipfs javadoc
Eirik Bjørsnøs
eirbjo at openjdk.org
Tue Feb 27 15:14:45 UTC 2024
On Mon, 26 Feb 2024 19:55:47 GMT, Lance Andersen <lancea at openjdk.org> wrote:
> This PR updates the javadoc and comments within java.util.zip/jar and zipfs module summary so that it is consistent with the use of "ZIP".
>
> In addition, open/src/java.base/share/classes/java/util/zip/package-info.java has been updated to point to the higher level location of the PKWARE APPNOTE.TXT has PKWare recently changed the direct path the the latest version of the spec.
>
> It is also worth noting that error messages were not updated as part of the PR and will be updated separately to keep the javadoc changes separate
Can you confirm that "zip" in `java.util.zip.ZipUtils.loadLibrary()` was intentionally left lowercase? (Presumably the native library should be referred to by lowercase "zip"):
https://github.com/openjdk/jdk/blob/c5c866aafe76f51cd5386bf5052c06691c1a0e8c/src/java.base/share/classes/java/util/zip/ZipUtils.java#L290
See separate feedback about the `ZipOutputStream.inhibitZip64` comment.
src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 54:
> 52: * Whether to use ZIP64 for zip files with more than 64k entries.
> 53: * Until ZIP64 support in zip implementations is ubiquitous, this
> 54: * system property allows the creation of zip files which can be
Suggestion:
* Whether to use ZIP64 for ZIP files with more than 64k entries.
* Until ZIP64 support in ZIP implementations is ubiquitous, this
* system property allows the creation of ZIP files which can be
-------------
PR Review: https://git.openjdk.org/jdk/pull/18011#pullrequestreview-1903793561
PR Review Comment: https://git.openjdk.org/jdk/pull/18011#discussion_r1504401597
More information about the core-libs-dev
mailing list